Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch - Minor fixups #1235

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 13, 2022

SUMMARY

Minor fixups from #859

Module hasn't been release yet, no need for changelog

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

opensearch
opensearch_info

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 13, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 13, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 5m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 41s
ansible-test-sanity-docker-devel FAILURE in 11m 45s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 20s
ansible-test-sanity-docker-stable-2.9 FAILURE in 11m 05s
ansible-test-sanity-docker-stable-2.11 FAILURE in 12m 16s
ansible-test-sanity-docker-stable-2.12 FAILURE in 11m 53s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 24s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 17s
✔️ ansible-test-splitter SUCCESS in 2m 27s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 01s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 59s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 39s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 30s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 20s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 44s
✔️ ansible-test-splitter SUCCESS in 2m 39s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 34s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 25s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 30s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 26s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 12s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 18s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 45s
✔️ ansible-test-splitter SUCCESS in 2m 27s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 634b02c into ansible-collections:main Jun 14, 2022
@tremble tremble deleted the opensearch/tweaks branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_snapshot_info/tests: add unit-tests

Depends-On: ansible-collections#1234
Depends-On: ansible-collections#1235
SUMMARY


Add the unit-test coverage of the ec2_snapshot_info module.
break up list_ec2_snapshots to move connection.describe_snapshots to  separate method.


COMPONENT NAME

ec2_snapshot_info
ADDITIONAL INFO
latest CI run coverage report  plugins_modules_ec2_snapshot_info_py.html

Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants